[Haskell] Barnsley Fern #851
Conversation
Amaras
added
the
Implementation
| to_choice x = (+ 1) $ length $ takeWhile (x >) cumulProbabilities | ||
|
|
||
| points = Point x y : zipWith (hutchinson !) (map to_choice picks) points | ||
|
|
There was a problem hiding this comment.
{-
Here is alternative code with IO monad instead of explicit Random Generator.
You do random generation in sequence anyway (through g, g' and g''),
so why not let IO monad care about the sequential stuff for you?
Then you won't even need newStdGen in main function, you work in IO already.
(This is the code without taking into account my other comments)
chaosGame :: Int -> [Double] -> Array Int (Point -> Point) -> IO [Point]
chaosGame n probabilities hutchinson = do
x <- randomIO
y <- randomIO
picks <- replicateM n $ randomRIO (0, 1)
let cumulProbabilities = scanl1 (+) probabilities
to_choice x = (+ 1) $ length $ takeWhile (x >) cumulProbabilities
points = Point x y : zipWith (hutchinson !) (map to_choice picks) points
return points
-}
There was a problem hiding this comment.
I usually try to stay away from IO until the very end. I feel code is more portable when it's pure. Yes, it's true that I'm doing IO in the end, but I want to focus more on the algorithm, and less on the task...
jiegillet
force-pushed
the
haskell-barnsley
branch
from
5d3dd07 to
67f2d3d
Compare
|
What do you think? Is this close to mergable? |
|
@leios I probed Seva a couple of times, but I guess he was too busy to check. He told before me that the initial code was already fine, and I've integrated all of his suggestions but one (with a valid reason) so I think this can be approved and merged, honestly. By you probably :) |
|
Ok, I thought that was what happened. Happy to merge it then! |
Seeing as #704 was reviewed recently, I'm pushing forward with Barnsley Fern.
I also fixed a typo in the chapter:
022->0.22.Output for 100k points:
